Skip to content

Fix C++20 build: don't name constructors with a template-id #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darrylabbate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix C++20 build: don't name constructors with a template-id #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src_cpp/HALO/halo_benchmark.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ class HaloBenchmark : public Benchmark {
if (rank >= required_nranks)
return;
}
DEFINE_INHERITED(HaloBenchmark<bs>, bs);
DEFINE_INHERITED(HaloBenchmark, bs);
};

}
Expand Down
2 changes: 1 addition & 1 deletion src_cpp/MT/MT_benchmark.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,5 +487,5 @@ template <class bs, mt_benchmark_func_t fn_ptr>
class BenchmarkMT : public BenchmarkMTBase<bs, fn_ptr> {
public:
virtual void init_flags();
DEFINE_INHERITED(GLUE_TYPENAME(BenchmarkMT<bs, fn_ptr>), bs);
DEFINE_INHERITED(BenchmarkMT, bs);
};
2 changes: 1 addition & 1 deletion src_cpp/helpers/original_benchmark.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,6 @@ class OriginalBenchmark : public Benchmark {
~OriginalBenchmark() {
free(BMark[0].name);
}
DEFINE_INHERITED(GLUE_TYPENAME(OriginalBenchmark<bs, fn_ptr>), bs);
DEFINE_INHERITED(OriginalBenchmark, bs);
};