-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] Introduce yarpgen testing #20829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
See https://github.com/intel/yarpgen Enabling on weekly basis.
|
@AlexeySachkov I'd like to get your review since you're familiar with this tool. |
| run: | | ||
| cd yarpgen | ||
| # A system hits OOM when using all available threads. | ||
| python3 scripts/run_gen.py --target clang -j4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For how long does it run by default? I suggest we set the duration here explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes just 10 minutes with this amount of jobs. I'm not sure if more jobs reduce the time or even increase:D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to set the time limit for this job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to set the time limit for this job?
I mean yarpgen can continue generating and trying programs indefinitely, if you say it so. My point was to pass -t/--timeout parameter explicitly to better indicate the intent here and don't depend on a default which might change
| # A system hits OOM when using all available threads. | ||
| python3 scripts/run_gen.py --target clang -j4 | ||
| - name: Pack results | ||
| run: tar -czf yarpgen_results.tar.gz yarpgen/testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope results aren't too huge. If they are, we can consider shorter retention policy if no issues were discovered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The archive takes just 1mb, as I understand without Intel SDE there are not many compiled programs. The issue is I have no idea how to download Intel SDE via console.
| name: yarpgen_results | ||
| path: yarpgen_results.tar.gz | ||
| retention-days: 7 | ||
| - name: Clean up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like this job to somehow report the fuzzing outcome. The tool does print some summary, but there are also errors which should not be considered as problems. For example, when a generated kernel uses too many arguments and they exceed implementation limits.
See https://github.com/intel/yarpgen
Enabling on weekly basis.