Skip to content

KVM: Add DMR APX test cases #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xhao22 merged 2 commits into from
Apr 3, 2026
Merged

KVM: Add DMR APX test cases #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7646a32
KVM: Add DMR APX test cases
xhao22 Mar 31, 2026
b722c67
Rename tests_* to tests-* in pmu fodler
xhao22 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 BM/pmu/tests_3fix_counters → BM/pmu/tests-3fix_counters
View file
Open in desktop
File renamed without changes.
0 BM/pmu/tests_arch_pebs → BM/pmu/tests-arch_pebs
View file
Open in desktop
File renamed without changes.
0 BM/pmu/tests_arch_perfmon_v6 → BM/pmu/tests-arch_perfmon_v6
View file
Open in desktop
File renamed without changes.
0 BM/pmu/tests_cwf → BM/pmu/tests-cwf
View file
Open in desktop
File renamed without changes.
0 BM/pmu/tests_dmr → BM/pmu/tests-dmr
View file
Open in desktop
File renamed without changes.
0 BM/pmu/tests_gnr → BM/pmu/tests-gnr
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions KVM/qemu/feature_test.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@
disable_parallel_run = yes
pre_command = 'echo 0 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel enable_mediated_pmu=Y'
post_command = 'echo 1 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel'
test_scen = "tests_arch_pebs"
test_scen = "tests-arch_pebs"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is focused on adding DMR APX test cases, but this hunk changes test_scen naming for PMU-related scenarios (PEBS / perfmon v6 / fix counters). If these renames are required, it would help to either (1) explain the linkage in the PR description, or (2) split these changes into a separate PR to keep the APX work isolated and easier to review/revert.

Copilot uses AI. Check for mistakes.
- arch_perfmon_v6:
no tdvm
feature_dir_names = "pmu"
disable_parallel_run = yes
pre_command = 'echo 0 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel enable_mediated_pmu=Y'
post_command = 'echo 1 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel'
test_scen = "tests_arch_perfmon_v6"
test_scen = "tests-arch_perfmon_v6"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is focused on adding DMR APX test cases, but this hunk changes test_scen naming for PMU-related scenarios (PEBS / perfmon v6 / fix counters). If these renames are required, it would help to either (1) explain the linkage in the PR description, or (2) split these changes into a separate PR to keep the APX work isolated and easier to review/revert.

Copilot uses AI. Check for mistakes.
- 3_fix_counters:
no tdvm
feature_dir_names = "pmu"
disable_parallel_run = yes
pre_command = 'echo 0 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel enable_mediated_pmu=Y'
post_command = 'echo 1 > /proc/sys/kernel/nmi_watchdog && modprobe -r kvm_intel && modprobe kvm_intel'
test_scen = "tests_3fix_counters"
test_scen = "tests-3fix_counters"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is focused on adding DMR APX test cases, but this hunk changes test_scen naming for PMU-related scenarios (PEBS / perfmon v6 / fix counters). If these renames are required, it would help to either (1) explain the linkage in the PR description, or (2) split these changes into a separate PR to keep the APX work isolated and easier to review/revert.

Copilot uses AI. Check for mistakes.
- cmpccxadd:
feature_dir_names = "cmpccxadd"
- lam:
Expand Down
6 changes: 6 additions & 0 deletions KVM/qemu/x86_cpuid.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
cpuid = "24 0 0 0 b 16, 24 0 0 0 b 17, 24 0 0 0 b 18, 24 0 1 0 c 2, 24 0 0 0 b 0:7 2"
- apx:
features = "APX"
- apx_xsave:
# User-level APX XSAVE area: CPUID.(EAX=0xD, ECX=19)
cpuid = "d 0 0x13 0 a 0:31 128, d 0 0x13 0 b 0:31 960, d 0 0x13 0 c 0:31 0"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CPUID entry mixes hex (0x13) with the surrounding config style that appears to use decimal operands (e.g., 24, 29). If the CPUID config parser expects a consistent numeric format, this may fail to parse or be inconsistent to maintain. Prefer using 19 (decimal) for ECX here, or whichever format is consistently used/guaranteed supported by the parser.

Suggested change
cpuid = "d 0 0x13 0 a 0:31 128, d 0 0x13 0 b 0:31 960, d 0 0x13 0 c 0:31 0"
cpuid = "d 0 19 0 a 0:31 128, d 0 19 0 b 0:31 960, d 0 19 0 c 0:31 0"

Copilot uses AI. Check for mistakes.
- apx_feature_bits:
# CPUID.29.0:EBX[0:0] APX_NCI_NDD_NF: 1
cpuid = "29 0 0 0 a 0:31 0, 29 0 0 0 b 0, 29 0 0 0 b 1:31 0, 29 0 0 0 c 0:31 0, 29 0 0 0 d 0:31 0"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apx_feature_bits comment says CPUID.29.0:EBX[0:0] ... : 1, but the CPUID string sets EBX bit 0 to 0 (... b 0 ...). Update the CPUID encoding so EBX[0] is set to 1 (and keep EBX[1:31]=0) to match the documented expected feature bit.

Suggested change
cpuid = "29 0 0 0 a 0:31 0, 29 0 0 0 b 0, 29 0 0 0 b 1:31 0, 29 0 0 0 c 0:31 0, 29 0 0 0 d 0:31 0"
cpuid = "29 0 0 0 a 0:31 0, 29 0 0 0 b 0:0 1, 29 0 0 0 b 1:31 0, 29 0 0 0 c 0:31 0, 29 0 0 0 d 0:31 0"

Copilot uses AI. Check for mistakes.
# CWF
- sha512:
features = "SHA512"
Expand Down
Loading