Allow older GPUs #188
Open
Allow older GPUs #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the code in linux/mfxloader.cpp and windows/main.cpp supports initializing the GPU using the legacy MFXInit() if MFXInitEx() is not available. However, the GPUs without MFXInitEx() are excluded by LoaderCtxVPL::CheckValidLibraries() in mfx_dispatcher_vp_loader.cpp. This inconsistency is addressed by this patch, which enables support for older GPUs without MFXInitEx(). Fixes: 17968d8 ("Release 2021.2.2") Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code in linux/mfxloader.cpp and windows/main.cpp supports initializing the GPU using the legacy MFXInit() if MFXInitEx() is not available. However, the GPUs without MFXInitEx() are excluded by LoaderCtxVPL::CheckValidLibraries() in mfx_dispatcher_vp_loader.cpp. This inconsistency is addressed by this patch, which enables support for older GPUs without MFXInitEx().
Fixes: 17968d8 ("Release 2021.2.2")
Issue
libvpl does not work with Intel HD Graphics embedded in Celeron 1005M, which has H.264 decoding feature via MFX API.
Solution
Check for the existence of
MFXInit()instead ofMFXInitEx()inLoaderCtxVPL::CheckValidLibraries().How Tested
Apply the proposed patch to cygwin libvpl package and run
mpv -vd h264_qsv videofile.mp4in my laptop with Celeron 1005M.