Skip to content

Promote the .val parameter, SIMICS-23405#416

Open
mandolaerik wants to merge 1 commit intointel:mainfrom
mandolaerik:pr/promote-the-val-parameter-simics-23405
Open

Promote the .val parameter, SIMICS-23405#416
mandolaerik wants to merge 1 commit intointel:mainfrom
mandolaerik:pr/promote-the-val-parameter-simics-23405

Conversation

@mandolaerik
Copy link
Contributor

No description provided.

@syssimics
Copy link
Contributor

PR Verification: ✅ success

The value of a field is stored in the corresponding bits of the containing
register's storage. The easiest way to access the value of a register or field
is to use the `get` and `set` methods.
register's storage. The easiest way to access the value of a field is to use the `val` parameter, which expands to a [bit slice expression](#bit-slicing-expressions) over the containing register's storage. The value of a field can also be accessed through [getter and setter methods](dml-builtins.html#templates-for-registers-and-fields).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth saying explicitly which methods. Probably get_val and set_val as they correspond to accessing val.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that but it got too spammy, which is why I changed it to a link. The text is intended to provide a brief overview of what a field is, so it is not relevant to delve into obscure details like get_val.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants