refactor(rebinding)!: remove two-phase prepare/finalize model#777
Merged
jyao1 merged 1 commit intointel:mainfrom Apr 7, 2026
Merged
refactor(rebinding)!: remove two-phase prepare/finalize model#777jyao1 merged 1 commit intointel:mainfrom
jyao1 merged 1 commit intointel:mainfrom
Conversation
MichalTarnacki
changed the title
Remove the two-phase rebinding model (PREPARE/FINALIZE) per GHCI 1.5: - Remove MIGTD_REBIND_OP_PREPARE/FINALIZE constants - Remove operation field from RebindingInfo struct - Adjust reserved field check (bytes 10-15 per spec) - Remove rebinding_old_finalize() and rebinding_new_finalize() - Simplify start_rebinding() to call prepare directly BREAKING CHANGE: RebindingInfo no longer contains an operation field Co-authored-by: Grams, Stanislaw <stanislaw.grams@intel.com>
MichalTarnacki
force-pushed
the
two-phase
branch
from
cbc9086 to
64aca25
Compare
jyao1
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(rebinding)!: remove two-phase prepare/finalize model
Remove the two-phase rebinding model (PREPARE/FINALIZE) per GHCI 1.5:
BREAKING CHANGE: RebindingInfo no longer contains an operation field