Completed Job application #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* stub the image_tag method * add an improved description
…link" * added require for Rails reverse_merge library file * added stub methods for profile_path, url_for_file_column, image_tag, and link_to * change to_s to to_str in Photo class
…ink" * refactored test methods & descriptions, and created common before block
…user is a rep user" * replaced code in helper.rb with call to has_valid_photo?, which exists in user_profile.rb, and is already stubbed * regroup tests again, update describe strings, and consolidate stuff in before blocks
…user is a regular user" * add stub methods to get test to pass
* modified code to return 'NO DEFAULT' instead of empty string * changed test to check for 'NO DEFAULT' for both types of users * removed useless line from code
* remove default_photo method * url_for_file_column, image_tag, profile_path, and link_to only appear once in the code * remove comment about 'this should not happen' - if that were the case there would be an exception/error, instead of a test
…, or huge * only testing the 'regular' user case so far
…a loop * restructure the test code so the test strings are more consistent * combined 'image_size' method in to new method * removed static "foo" method that seemed useless
Get the commits for Ruby on Rails from Github using the JSON API and print the results in HTML format using and ERB template.
…ser case * fixed bug with missing = in code
* Not needed for running spec from the command line
* Not that important or useful right now, but README seemed to indicate it was desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threw in a PHP version of the github script as well.
See you in a few hours.