Skip to content

Avoid shell usage in dependency checker#10

Merged
bsbodden merged 1 commit into
mainfrom
issue-5-check-deps-no-shell
May 17, 2026
Merged

Avoid shell usage in dependency checker#10
bsbodden merged 1 commit into
mainfrom
issue-5-check-deps-no-shell

Conversation

@bsbodden

Copy link
Copy Markdown
Member

Summary

  • Replace curl via subprocess.run(..., shell=True) with urllib.request
  • Refactor the dependency checker into small testable functions
  • Add a regression test that rejects shell=True

Closes #5

Tests

  • uv run pytest tests/test_check_deps_script.py -q
  • uv run ruff check .

@bsbodden bsbodden force-pushed the issue-5-check-deps-no-shell branch 2 times, most recently from e58a73a to a4db16d Compare May 16, 2026 22:34
@github-actions

Copy link
Copy Markdown
Contributor

✅ MFCQI Score: 0.87 → (±0.000)

➡️ Previous: 0.87

Code quality meets the minimum threshold (0.70).

@bsbodden bsbodden force-pushed the issue-5-check-deps-no-shell branch from a4db16d to d6d1ff3 Compare May 16, 2026 22:39
@github-actions

Copy link
Copy Markdown
Contributor

✅ MFCQI Score: 0.87 → (±0.000)

➡️ Previous: 0.87

Code quality meets the minimum threshold (0.70).

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Quality Report

Metric Score Status
MFCQI Score 0.8710511435045868 ✅ Good
Test Coverage 82% ✅ Good
Security Issues 0 ✅ Clean

Quality Gates

  • MFCQI Score: ✅ Minimum 0.75 (Current: 0.8710511435045868)
  • Test Coverage: ✅ Minimum 80% (Current: 82%)
  • Security: ✅ Zero vulnerabilities (Current: 0)

🎉 All quality gates passed! This PR maintains high code quality standards.

📊 View detailed MFCQI breakdown

Run mfcqi analyze src/mfcqi locally to see detailed metrics breakdown.

@bsbodden bsbodden force-pushed the issue-5-check-deps-no-shell branch from d6d1ff3 to db5a6eb Compare May 17, 2026 00:27
@github-actions

Copy link
Copy Markdown
Contributor

✅ MFCQI Score: 0.87 → (±0.000)

➡️ Previous: 0.87

Code quality meets the minimum threshold (0.70).

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Quality Report

Metric Score Status
MFCQI Score 0.8715710274260666 ✅ Good
Test Coverage 81% ✅ Good
Security Issues 0 ✅ Clean

Quality Gates

  • MFCQI Score: ✅ Minimum 0.75 (Current: 0.8715710274260666)
  • Test Coverage: ✅ Minimum 80% (Current: 81%)
  • Security: ✅ Zero vulnerabilities (Current: 0)

🎉 All quality gates passed! This PR maintains high code quality standards.

📊 View detailed MFCQI breakdown

Run mfcqi analyze src/mfcqi locally to see detailed metrics breakdown.

@bsbodden bsbodden merged commit 8302147 into main May 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid shell=True in dependency conflict check script

1 participant