Conversation
- fix the Linux PTY loop call sites and borrow lifetimes so the interactive recorder compiles cleanly in CI - reborrow the PTY and stdin buffers correctly in the extracted helpers - keep the recorder rewrite intact while restoring a clean local just check run
- remove the non-linux portable PTY recorder path and fail closed outside linux\n- scope recording dependencies to linux-only targets and drop portable-pty\n- keep the linux recorder path unchanged while simplifying the supported platform surface
- reduce linux recorder helper complexity to satisfy strict clippy gates\n- keep the linux-only recording restriction and dropped portable PTY path intact\n- preserve the existing linux recorder behavior while making the branch pass just check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.