[MBL-19569][Student] - Implement New To Do E2E Tests#3451
Merged
kdeakinstructure merged 6 commits intomasterfrom Jan 5, 2026
Merged
[MBL-19569][Student] - Implement New To Do E2E Tests#3451kdeakinstructure merged 6 commits intomasterfrom
kdeakinstructure merged 6 commits intomasterfrom
Conversation
Fix favorite courses dataseeding process. refs: MBL-19569 affects: Student release note:
…nd todos, past item filters). Fix dataseeding issue with favorite course filter logic. Implement PlannerAPI for seeding calendar todos. Add and modify some apimodels. Add many page objects methods. refs: MBL-19569 affects: Student release note:
…udentTest. refs: MBL-19569 affects: Student release note:
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR significantly enhances the To-Do feature with comprehensive E2E testing and improved filter functionality. The implementation looks solid overall with good test coverage and proper use of Compose testing patterns.
✅ Strengths
- Comprehensive test coverage: Three new E2E tests thoroughly cover the To-Do list functionality including filters, calendar events, personal to-dos, and swipe gestures
- Well-structured tests: Clear test organization with descriptive logging at each step following the PREPARATION/STEP/ASSERTION pattern
- Good use of Compose testing: Proper use of test tags, semantic matching, and the page object pattern
- API integration: New
PlannerAPIproperly integrated with consistent patterns - Accessibility improvements: Better semantic descriptions and test tag organization for UI components
⚠️ Issues Found
- Critical Logic Error (SeedApi.kt:145) - Unused lambda in favorite courses seeding. The lambda wraps the logic but is never executed, causing the favorite courses feature to silently fail. This needs immediate attention.
- Code cleanup needed - Several commented-out code sections that should be removed (CalendarScreenPage.kt:84)
- Formatting inconsistencies - Extra whitespace and blank lines that don't match project style
📋 Code Quality Observations
Positive:
- Consistent use of data seeding patterns for test setup
- Proper handling of calendar-specific edge cases (Sunday checks)
- Good separation of concerns with dedicated filter page objects
- Appropriate use of Kotlin idioms and coroutines
Minor Improvements:
- Consider more specific test tags for better test reliability
- Some test assertions could be more descriptive about expected vs actual states
🔒 Security & Performance
No security concerns identified. The changes are test-focused with proper data isolation. Performance should be unaffected as changes are primarily in test code.
🧪 Test Coverage
Excellent test coverage with three comprehensive E2E tests covering:
- Main To-Do functionality with various date range filters
- Past date filters with edge case handling
- Calendar events, personal to-dos, and swipe gestures
Recommendation
Fix the critical lambda issue in SeedApi.kt before merging, as it will cause the favorite courses feature to not work correctly in tests. The other issues are minor cleanup items that should also be addressed for code quality.
Great work on the comprehensive testing! The filter functionality looks well-designed and thoroughly tested.
Contributor
📊 Code Coverage Report✅ Student
✅ Teacher
|
Contributor
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Mon, 05 Jan 2026 12:04:00 GMT |
Contributor
|
Student Install Page |
tamaskozmer
requested changes
Jan 5, 2026
tamaskozmer
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan
Changes
refs: MBL-19569
affects: Student
release note: none