Skip to content

s390x support#755

Merged
pvital merged 4 commits into
instana:mainfrom
pvital:s390x_support
Jul 1, 2025
Merged

s390x support#755
pvital merged 4 commits into
instana:mainfrom
pvital:s390x_support

Conversation

@pvital

@pvital pvital commented Jun 30, 2025

Copy link
Copy Markdown
Member

This PR adds support for s390x (IBM Z).

@pvital pvital self-assigned this Jun 30, 2025
@pvital pvital requested a review from a team as a code owner June 30, 2025 14:02

@arjun-rajappa arjun-rajappa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests_aws/conftest.py Outdated
Comment thread tests_aws/conftest.py

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests:)

@pvital pvital requested a review from GSVarsha July 1, 2025 07:29
@pvital pvital changed the title S390x support s390x support Jul 1, 2025
Comment thread tests_aws/conftest.py Outdated
@pvital pvital requested a review from GSVarsha July 1, 2025 09:30

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

pvital added 4 commits July 1, 2025 11:35
The following tests are not executed in a s390x (Z) environment due to lack of support to run them:

- google-cloud-*: no support to s390x.
- pymongo: only the Enterprise edition is supported in s390x.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
This change handles similar OperationalError messages raised by different architectures.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Avoiding the raise of a NotImplementedError when calling multiprocessing.Queue.qsize().

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital pvital merged commit fd363b2 into instana:main Jul 1, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants