Fixing the class checks and some minors #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melkiades
commented
Jan 21, 2026
Contributor
Author
Melkiades
left a comment
Melkiades
left a comment
There was a problem hiding this comment.
I think this is ready
Melkiades
commented
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in class checking logic and adds improvements to the save_with_rmarkdown() function. The changes ensure proper detection of table classes when working with lists of tables, add path normalization for reliable file output, and expand test coverage to include gtsummary tables.
Changes:
- Fixed bug in
pkg_to_attachlogic that was incorrectly callingclass()on already-extracted class vectors - Added path normalization to ensure output files are created in the correct location
- Added new test coverage for gtsummary tables and file existence verification
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| R/save_with_rmarkdown.R | Fixed class checking bug, added path normalization, updated documentation examples |
| man/save_with_rmarkdown.Rd | Updated documentation examples to show flextable and gt usage |
| tests/testthat/test-save_with_rmarkdown.R | Added file existence checks and new test for gtsummary tables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github copilot suggestions Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: b_falquet <64274616+BFalquet@users.noreply.github.com>
BFalquet
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should get the defaults from other packages for this section :)