-
-
Notifications
You must be signed in to change notification settings - Fork 3
Sets flextable layout to fixed #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
Code Coverage SummaryDiff against mainResults for commit: 8f3d642 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 73 suites 1m 49s ⏱️ Results for commit 8f3d642. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit bb779b7 ♻️ This comment has been updated with latest results. |
|
@BFalquet I think it is fine, but I want to understand a bit better the final look and expected work from the user. Could you add a comment/documentation where you change the layout? similarly to what you showed in the issue |
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this for now, due to further discussion. I do not think "fixed" would work as all tables would have too large or too small widths that do not fit the margin. Attempting to estimate the user's expected width would be often incorrect/unprecise. Also, "autofit" aims at fitting the margins automatically, which is a feature much easier and common to achieve
What changes are proposed in this pull request?
Updates the
theme_gtsummary_rochefunction to set the defaultflextablelayout property to "fixed" instead of "autofit".Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #150
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).