Skip to content

Conversation

@edwardsph
Copy link

No description provided.

@edwardsph edwardsph requested a review from acoburn January 31, 2025 17:47
Copy link

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I especially like the way the workflow is dependent on the existence of the various GH secrets

name: code-coverage
path: coverage/

sonarqube:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might just call this sonar

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will now that this is internally focussed. The default proposed by Sonar is sonarqube

@edwardsph edwardsph merged commit 2fc96a9 into main Jan 31, 2025
0 of 2 checks passed
NSeydoux pushed a commit that referenced this pull request Apr 24, 2025
…and_yarn/multi-7849d5103f

Bump send, expo and @config-plugins/detox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants