Skip to content

SNARK-friendly STM: jubjub wrapper #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
curiecrypt wants to merge 7 commits into
base: main
Choose a base branch
from
Open

SNARK-friendly STM: jubjub wrapper #2828

curiecrypt wants to merge 7 commits into from

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Dec 1, 2025 •
edited
Loading

Content

This PR includes the jubjub wrapper for the schnorr_signature module.
The jubjub exposer, located in ../schnorr_signature/jubjub/, includes:

  • curve_points
  • field_elements
  • poseidon_digest
    It exposes the jubjub functionality (from dusk for today) required by the Schnorr signature.

This wrapper removed all dusk imports from the Schnorr implementation.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Comments

Issue(s)

Closes #2817

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

Test Results

    4 files  ±0    169 suites  ±0   24m 18s ⏱️ + 1m 20s
2 278 tests ±0  2 278 ✅ ±0  0 💤 ±0  0 ❌ ±0 
7 146 runs  ±0  7 146 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 792dafa. ± Comparison against base commit 3199222.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 3, 2025
View reviewed changes
@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/jubjub-wrapper branch from bdab491 to dc04ec6 Compare December 3, 2025 18:02
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2025
View reviewed changes
@curiecrypt curiecrypt marked this pull request as ready for review December 5, 2025 15:35
@curiecrypt curiecrypt requested a review from jpraynaud December 5, 2025 15:48
jpraynaud
jpraynaud reviewed Dec 8, 2025
View reviewed changes
@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/jubjub-wrapper branch from 7f64ad9 to bbc3b2e Compare December 17, 2025 22:16
hjeljeli32
hjeljeli32 approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@hjeljeli32 hjeljeli32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
I left 2 small non-blocking suggestions (DST choice + tests/golden coverage). Otherwise, looks solid to me.

@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/jubjub-wrapper branch from bbc3b2e to 21a7359 Compare December 19, 2025 15:45
damrobi
damrobi approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@damrobi damrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpraynaud
jpraynaud approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/jubjub-wrapper branch from 21a7359 to bfa1314 Compare December 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@damrobi damrobi damrobi approved these changes

@hjeljeli32 hjeljeli32 hjeljeli32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Jubjub/Poseidon backends wrappers in Schnorr signature scheme

5 participants

@curiecrypt @jpraynaud @damrobi @hjeljeli32