Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 15, 2025

Description

Refactor catalyst-signed-doc tests utilities code, moving it as a public mod catalyst_signed_doc::tests_utils.

Related Issue(s)

Needed for #691

Description of Changes

  • Deleted tests/common mod, moved all the code to the catalyst_signed_doc::tests_utils.
  • Removed duplicated create_dummy_key_pair, create_dummy_doc_ref.
  • Split create_dummy_key_pair(Option<RoleId>) to create_dummy_key_pair(RoleId) and create_dummy_admin_key_pair
  • Updated existing tests.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review December 15, 2025 05:56
@Mr-Leshiy Mr-Leshiy added squad: gatekeepers Catalyst App Backend, System Development & Integration Team review me PR is ready for review labels Dec 15, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Dec 15, 2025
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/refactor-tests

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Test Report | ${\color{lightgreen}Pass: 633/633}$ | ${\color{red}Fail: 0/633}$ |

@Mr-Leshiy Mr-Leshiy merged commit edd167f into main Dec 15, 2025
11 of 13 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Dec 15, 2025
@Mr-Leshiy Mr-Leshiy deleted the feat/refactor-tests branch December 15, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants