Add Pool data models with comprehensive test coverage#3
Merged
Conversation
- Add OtherAsset model with DateLastEvaluated date parsing - Add OtherLiability model with MaturityDate and PaymentNextDue parsing - Add Pool model with nested objects and multiple date field support - Add PoolResponse wrapper for single pool API responses - Add PoolsResponse wrapper handling both list and single pool responses - Update PoolsResource to return typed Pool objects instead of dicts - Add 14 comprehensive tests covering all Pool model classes - Fix PoolsResponse to handle empty dict edge case correctly - All 111 tests passing with 91% code coverage maintained 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Add SysTimeStamp field to test_pool_initialization test data - Add assertions to verify SysTimeStamp is parsed correctly - Improves code coverage from 91% to 92% - Fixes codecov missing line 44 in pool.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code