tui/pg: dedupe render helpers, share SQL, add coverage#1
Merged
Conversation
Quality pass over the whole codebase (no behaviour change). Simplification / reuse: - Unify the info-overlay scaffolding into shared row.go helpers: padInfo (was 2 private copies + 14 inline loops), infoHeader (1 helper + 15 copies), and swatch for the "▇" legend glyph. - Collapse the three per-function bar-cell closures in row.go into one bytesToCells helper; add screen.resetCursor() for the paired cursor/offset resets. - Move the generic fmt* formatters from view_queries.go to format.go where their other consumers live. - Quote SQL identifiers via the existing qualifiedIdent() in bloat/reindex/vacuum instead of Go %q. - Build sqlBufferStats / sqlBufferStatByOID from one template (was ~50 duplicated lines); generated SQL is byte-identical to the old consts. Tests: shmemCatOf ordering, appliedWindowPaths/snapTime snapshot anchors, the statements column registry (uniqueness, track_planning gating, toggles, cells∥columns parallelism), containsFold vs a strings.Contains oracle, lessBy*Extractor unknown-below-known, viewportRange boundaries, barWidth clamps, a barReserve smoke test, and QueryStat derived-metric edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass over the whole codebase (no behaviour change).
Simplification / reuse:
Tests: shmemCatOf ordering, appliedWindowPaths/snapTime snapshot anchors, the statements column registry (uniqueness, track_planning gating, toggles, cells∥columns parallelism), containsFold vs a strings.Contains oracle, lessBy*Extractor unknown-below-known, viewportRange boundaries, barWidth clamps, a barReserve smoke test, and QueryStat derived-metric edges.