Conversation
| .format(tempfile, remote_path, mode) | ||
| ) | ||
| conn = self._get_connection() | ||
| tempfile = '/tmp/' + str(uuid4()) |
Contributor
There was a problem hiding this comment.
There is mktemp in Python, maybe it could be used here.
Member
Author
There was a problem hiding this comment.
in this case we create the /tmp/ on the target host. with mktemp we can only to it locally. I keep it as it is to keep changes (kinda) low
brainexe
force-pushed
the
fabric
branch
2 times, most recently
from
89b439e to
660f8e1
Compare
brainexe
changed the title
brainexe
force-pushed
the
fabric
branch
2 times, most recently
from
13bb332 to
fc1e10b
Compare
lamaral
approved these changes
Mar 3, 2026
Contributor
lamaral
left a comment
lamaral
left a comment
There was a problem hiding this comment.
I did some limited testing and couldn't break it, so LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current Fabric3 is quite outdated and causing more and more compatibility issues (like python3.13)
-> use the maintained "fabric" version
already tested: basic VM start/stop/build/delete/sync/info/restart/disk-set/mem-set
todo: migration (offline + online) / AWS / rename / vcpu-set