fix issue with adding multiple routes#6
Open
Kiyoshika wants to merge 1 commit intoinfraredCoding:masterfrom
Open
fix issue with adding multiple routes#6Kiyoshika wants to merge 1 commit intoinfraredCoding:masterfrom
Kiyoshika wants to merge 1 commit intoinfraredCoding:masterfrom
Conversation
I slightly redesigned the addRoute function. Instead of trying to return routes to update it, we pass the pointer by address to modify it directly. Otherwise I believe we'd be assigning to the copied pointers on the parameter stack instead of the actual route pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is aimed to address issue #3
I slightly redesigned the addRoute function. Instead of trying to return routes to update it, we pass the pointer by address to modify it directly. Otherwise I believe we'd be assigning to the copied pointers on the parameter stack instead of the actual route pointer.
See attached video for it in action.
cerveur.routes.mp4