Expand CODING_STANDARD.md with comprehensive guidelines #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add detailed standards for Python, Terraform, and Makefile conventions: Python Standards: - Code formatting (Black), linting (pylint), type hints (required) - Testing philosophy (meaningful tests, no coverage requirements) - Error handling (never use bare except Exception) - Logging (setup_logging from infrahouse_core) - InfraHouse packages architecture (infrahouse-core vs infrahouse-toolkit) Terraform Standards: - Naming conventions (snake_case, boolean prefixes, resource patterns) - Complete variable guidelines (types, defaults, validation, sensitive) - Output standards, documentation requirements - Resource organization (count vs for_each, locals, file structure) - Comprehensive security (secrets, encryption, logging, ISO/SOC compliance) - Expanded validation examples (including nullable ternary operator pattern) - IAM policy patterns, tagging conventions, testing workflow Makefile Standards: - Required targets (help, bootstrap, install-hooks, test, clean, format, lint, release-*) - Target naming conventions and PHONY declarations - Examples for common patterns
|
Comment was too big. Check the CI workflow output. |
infrahouse8
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detailed standards for Python, Terraform, and Makefile conventions:
Python Standards:
Terraform Standards:
Makefile Standards: