Open
Conversation
And move crates from regular to dev-dependencies when they're only used in tests. Found by the unused crate lint and removed to help prevent unnecessary dependency hell when upgrading hyper to 1.0, but committed separately from enabling the lint permanently.
But allow/expect/explicitly `use as _` for false positives of the lint because it isn't possible to currently specify that a dependency is only used in unit tests but not integration tests, or only used in a benchmark but not unit tests, or only used in the bin but not the lib. See these issues: - <rust-lang/rust#57274> - <rust-lang/rust#95513>
hiltontj
approved these changes
Jul 2, 2025
Contributor
hiltontj
left a comment
hiltontj
left a comment
There was a problem hiding this comment.
This is a welcome change IMHO - though it has been some time since the PR was opened so a rebase/merge is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move crates from regular to dev-dependencies when they're only used in tests.
Found by the unused crate lint and removed to help prevent unnecessary dependency hell when upgrading hyper to 1.0, but committed separately from enabling the lint permanently.
This lint has a number of "false positives" that are due to being unable to specify per-target dependencies; see these issues for more info:
unused_crate_dependenciesfalse-positives in Cargo packages with muliple Cargo Targets (lib, bins, examples, tests, benches) rust-lang/rust#95513I'm most interested in the first commit here that cleans up existing unused crates.
I won't be offended if you don't want the second commit that will make you have to clean up or explicitly allow actual unused crates or false positives going forward. I'm happy to rebase out the 2nd commit, just say the word!