Skip to content

chore(deps): Bump github.com/inference-gateway/adk from 0.17.3 to 0.18.1#510

Merged
edenreich merged 5 commits into
mainfrom
dependabot/go_modules/github.com/inference-gateway/adk-0.18.1
May 13, 2026
Merged

chore(deps): Bump github.com/inference-gateway/adk from 0.17.3 to 0.18.1#510
edenreich merged 5 commits into
mainfrom
dependabot/go_modules/github.com/inference-gateway/adk-0.18.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 13, 2026

Bumps github.com/inference-gateway/adk from 0.17.3 to 0.18.1.

Release notes

Sourced from github.com/inference-gateway/adk's releases.

🚀 Version 0.18.1

0.18.1 (2026-05-13)

👷 CI

  • deps: Bump actions/create-github-app-token from 3.1.1 to 3.2.0 (#139) (c0380a0)
  • deps: Bump actions/setup-node from 6.3.0 to 6.4.0 (#140) (92db606)
  • deps: Bump anthropics/claude-code-action from 1.0.114 to 1.0.121 (#138) (051c0df)
  • Fix deprecation warning (bf6c03a)

🔧 Miscellaneous

  • Configure Dependabot for gomod and GitHub Actions (51846a8)

🔨 Miscellaneous

  • deps: Bump github.com/cloudevents/sdk-go/v2 from 2.15.2 to 2.16.2 (#145) (e633efa)
  • deps: Bump github.com/coreos/go-oidc/v3 from 3.14.1 to 3.18.0 (#143) (8f62fba)
  • deps: Bump github.com/gin-gonic/gin from 1.10.1 to 1.12.0 (#144) (c8cc742)
  • deps: Bump github.com/minio/minio-go/v7 from 7.0.78 to 7.1.0 (#142) (4944c11)
  • deps: Bump go.opentelemetry.io/otel/metric from 1.36.0 to 1.43.0 (#141) (16d6ffb)

🚀 Version 0.18.0

0.18.0 (2026-05-13)

✨ Features

  • a2a: Implement missing A2A JSON-RPC methods (#134) (0c71b87), closes #132

♻️ Improvements

  • Delete .github/copilot-instructions.md (f1c96f2)

👷 CI

  • Enable commit signing for Claude Code action (4369a37)

📚 Documentation

  • examples: Add protocol-methods example covering remaining A2A JSON-RPC methods (#135) (2af77ad), closes #133

🔧 Miscellaneous

  • Add CODEOWNERS file for repository ownership (45591f7)
  • deps: Bump inference-gateway/sdk to v1.16.3 and golang to 1.26.2 (#137) (7da8f01)
  • Remove outdated issue templates for bug reports, feature requests, and refactor requests (735917c)
Changelog

Sourced from github.com/inference-gateway/adk's changelog.

0.18.1 (2026-05-13)

👷 CI

  • deps: Bump actions/create-github-app-token from 3.1.1 to 3.2.0 (#139) (c0380a0)
  • deps: Bump actions/setup-node from 6.3.0 to 6.4.0 (#140) (92db606)
  • deps: Bump anthropics/claude-code-action from 1.0.114 to 1.0.121 (#138) (051c0df)
  • Fix deprecation warning (bf6c03a)

🔧 Miscellaneous

  • Configure Dependabot for gomod and GitHub Actions (51846a8)

🔨 Miscellaneous

  • deps: Bump github.com/cloudevents/sdk-go/v2 from 2.15.2 to 2.16.2 (#145) (e633efa)
  • deps: Bump github.com/coreos/go-oidc/v3 from 3.14.1 to 3.18.0 (#143) (8f62fba)
  • deps: Bump github.com/gin-gonic/gin from 1.10.1 to 1.12.0 (#144) (c8cc742)
  • deps: Bump github.com/minio/minio-go/v7 from 7.0.78 to 7.1.0 (#142) (4944c11)
  • deps: Bump go.opentelemetry.io/otel/metric from 1.36.0 to 1.43.0 (#141) (16d6ffb)

0.18.0 (2026-05-13)

✨ Features

  • a2a: Implement missing A2A JSON-RPC methods (#134) (0c71b87), closes #132

♻️ Improvements

  • Delete .github/copilot-instructions.md (f1c96f2)

👷 CI

  • Enable commit signing for Claude Code action (4369a37)

📚 Documentation

  • examples: Add protocol-methods example covering remaining A2A JSON-RPC methods (#135) (2af77ad), closes #133

🔧 Miscellaneous

  • Add CODEOWNERS file for repository ownership (45591f7)
  • deps: Bump inference-gateway/sdk to v1.16.3 and golang to 1.26.2 (#137) (7da8f01)
  • Remove outdated issue templates for bug reports, feature requests, and refactor requests (735917c)
Commits
  • 3627647 chore(release): 🔖 0.18.1 [skip ci]
  • e633efa build(deps): Bump github.com/cloudevents/sdk-go/v2 from 2.15.2 to 2.16.2 (#145)
  • c8cc742 build(deps): Bump github.com/gin-gonic/gin from 1.10.1 to 1.12.0 (#144)
  • 8f62fba build(deps): Bump github.com/coreos/go-oidc/v3 from 3.14.1 to 3.18.0 (#143)
  • 4944c11 build(deps): Bump github.com/minio/minio-go/v7 from 7.0.78 to 7.1.0 (#142)
  • 16d6ffb build(deps): Bump go.opentelemetry.io/otel/metric from 1.36.0 to 1.43.0 (#141)
  • 92db606 ci(deps): Bump actions/setup-node from 6.3.0 to 6.4.0 (#140)
  • c0380a0 ci(deps): Bump actions/create-github-app-token from 3.1.1 to 3.2.0 (#139)
  • 051c0df ci(deps): Bump anthropics/claude-code-action from 1.0.114 to 1.0.121 (#138)
  • 51846a8 chore: Configure Dependabot for gomod and GitHub Actions
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/inference-gateway/adk](https://github.com/inference-gateway/adk) from 0.17.3 to 0.18.1.
- [Release notes](https://github.com/inference-gateway/adk/releases)
- [Changelog](https://github.com/inference-gateway/adk/blob/main/CHANGELOG.md)
- [Commits](inference-gateway/adk@v0.17.3...v0.18.1)

---
updated-dependencies:
- dependency-name: github.com/inference-gateway/adk
  dependency-version: 0.18.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels May 13, 2026
@dependabot dependabot Bot requested a review from a team as a code owner May 13, 2026 19:24
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels May 13, 2026
Comment thread go.mod Outdated
Co-authored-by: Eden Reich <eden.reich@gmail.com>
@edenreich
Copy link
Copy Markdown
Contributor

@claude Can you fix it?

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 13, 2026

Claude finished @edenreich's task in 4m 23s —— View job


Fixed CI failure

The go.mod was already at v0.18.1 (Eden's suggestion applied in 937e1b8) — the actual problem was the vet job failing because ADK v0.18.0 expanded the client.A2AClient interface, leaving the local test mock incomplete.

Vet error:

internal/agent/tools/a2a_task_error_handling_test.go:145:56: cannot use mockClient (variable of type *MockA2AClient) as client.A2AClient value in argument to NewA2ASubmitTaskToolWithClient: *MockA2AClient does not implement client.A2AClient (missing method DeleteTaskPushNotificationConfig)

Fix (commit 00c19fe): Added six no-op stub methods to MockA2AClient in internal/agent/tools/a2a_task_error_handling_test.go so it satisfies the new interface:

  • GetAuthenticatedExtendedCard
  • ResubscribeTask
  • SetTaskPushNotificationConfig
  • GetTaskPushNotificationConfig
  • ListTaskPushNotificationConfig
  • DeleteTaskPushNotificationConfig

Verified locally:

  • go vet ./... → clean
  • go build ./... → clean
  • go test ./internal/agent/tools/... -run TestA2Aok (6.17s)

Checklist

  • Read current go.mod (already at v0.18.1)
  • Identify CI failure root cause (interface mismatch, not go.mod)
  • Add the six missing methods as no-op stubs on MockA2AClient
  • Run go vet, go build, and the affected tests locally
  • Commit fix to the PR branch
    Branch

…face

ADK v0.18.0 added several A2A JSON-RPC methods to the client.A2AClient
interface (push notification config CRUD, ResubscribeTask, and
GetAuthenticatedExtendedCard). Add no-op stubs on the local
MockA2AClient so it continues to satisfy the interface and `go vet`
passes.

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
@edenreich
Copy link
Copy Markdown
Contributor

@claude Please refactor - why don't we use a mocking library like counterfeiter for example? why writting the mocks manually?

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 13, 2026

Claude finished @edenreich's task in 5m 4s —— View job


Refactored: counterfeiter-generated mock for A2AClient

Great catch — the hand-written MockA2AClient was an outlier. Every other interface in the project is mocked via counterfeiter (task mocks:generate), so the v0.18 bump needing manual stubs was a symptom of that drift, not something to paper over.

What changed (commit e352367)

  • Deleted the 50-line hand-written MockA2AClient from internal/agent/tools/a2a_task_error_handling_test.go.
  • Generated tests/mocks/adk/fake_a2aclient.go via counterfeiter, pointed at the upstream interface:
    counterfeiter -o tests/mocks/adk github.com/inference-gateway/adk/client.A2AClient
    
  • Wired it into task mocks:generate (Taskfile.yml) so future adk upgrades regenerate the fake automatically — no more chasing interface drift by hand.
  • Rewrote the test bodies to use the standard counterfeiter API (mockClient.SendTaskReturns(...), mockClient.GetTaskReturns(...)), matching how the rest of the codebase uses mocks.FakeA2ATaskTracker etc.

Net result

 Taskfile.yml                                          |   3 +
 internal/agent/tools/a2a_task_error_handling_test.go  | 106 +++-------------
 tests/mocks/adk/fake_a2aclient.go                     | 1365 +++++++++ (generated)

The hand-written file shrunk -89 lines net in the test, and the upstream interface is now mocked uniformly with the rest of the project.

Verified locally

  • go vet ./... → clean
  • go build ./... → clean
  • go test ./internal/agent/tools/... -run TestA2A -count=1ok (6.20s)
  • go test ./... -count=1 → all packages ok (full suite, no failures)

Why this is better than manual stubs

  1. Single source of truth. When adk adds a method, regenerating picks it up — no compile errors waiting for a human to notice.
  2. Richer assertions for free. CallCount(), ArgsForCall(i), ReturnsOnCall(i, …) are now available on the A2A client in tests, matching what we already do with FakeA2ATaskTracker.
  3. Consistency. Every other interface in the repo follows this pattern; the manual mock was the only exception.

Checklist

  • Read the hand-written mock & the upstream A2AClient interface
  • Generate FakeA2AClient with counterfeiter into tests/mocks/adk/
  • Add the generation step to task mocks:generate (Taskfile.yml)
  • Refactor tests to use adkmocks.FakeA2AClient + …Returns(...) API
  • Delete the hand-written MockA2AClient
  • go vet / go build / full go test ./... all green
  • Commit pushed to the PR branch
    Branch

…er-generated fake

The hand-written MockA2AClient in a2a_task_error_handling_test.go duplicated
work that the rest of the codebase already delegates to counterfeiter, and
needed manual updates every time the upstream adk A2AClient interface grew
(as in the v0.18.0 bump). Replace it with a generated FakeA2AClient pointed
at github.com/inference-gateway/adk/client.A2AClient, and wire the mock into
the existing `task mocks:generate` target so future adk upgrades regenerate
it automatically.

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
@edenreich edenreich merged commit 0ff9118 into main May 13, 2026
5 checks passed
@edenreich edenreich deleted the dependabot/go_modules/github.com/inference-gateway/adk-0.18.1 branch May 13, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant