Skip to content

Conversation

@alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Sep 2, 2025

This adds the JOSS paper to the doc folder and includes a CI action to build it.

NOTE: This PR will not be merged! It is a place to discuss the JOSS paper and make modifications during review.

@alexfikl alexfikl force-pushed the joss branch 4 times, most recently from 0f08356 to 68f92ff Compare September 2, 2025 13:12
@alexfikl alexfikl marked this pull request as ready for review September 2, 2025 13:12
@alexfikl
Copy link
Collaborator Author

alexfikl commented Sep 2, 2025

The generated paper can be found in the workflow outputs: https://github.com/inducer/modepy/actions/runs/17404604638. It looks good to me! 😁

@inducer
Copy link
Owner

inducer commented Sep 2, 2025

Thanks for getting this finished up! That said, I'm not sure the modepy repo is the right spot for it. I don't intend to "maintain" the paper in the same way I intend to maintain the docs or the code. Once it's finished, it's finished in my opinion, and the archival copy will live at JOSS. We can link to it, but IMO it's not great to include it here.

@alexfikl
Copy link
Collaborator Author

alexfikl commented Sep 2, 2025

Thanks for getting this finished up! That said, I'm not sure the modepy repo is the right spot for it. I don't intend to "maintain" the paper in the same way I intend to maintain the docs or the code. Once it's finished, it's finished in my opinion, and the archival copy will live at JOSS. We can link to it, but IMO it's not great to include it here.

My understanding of their submission documentation (from https://joss.readthedocs.io/en/latest/submitting.html#submission-process) is that the paper should be in the same repository somewhere. The submission form also has a Name of git branch containing the paper field, so it seems like they expect it to be somewhere in the repo.

We could make this a "branch" with no other history and just leave it there. Would that be ok? I mostly just made this PR to make sure that the build works, but I'm fine with not actually merging it into main.

@inducer
Copy link
Owner

inducer commented Sep 3, 2025

Reading their submission guidelines, I don't see anywhere that explicitly says that the paper has to be in the same repo as the code. And I'm not a huge fan of branch-is-separate-thing, it feels like that's holding git wrong.

My read of the guidelines is that they want a repo (which IMO makes sense for change tracking) but aren't particular about which. As such, I think I'd be happiest if we could just move https://gitlab.tiker.net/papers/2025-modepy-joss someplace public.

What do you think?

@inducer
Copy link
Owner

inducer commented Sep 3, 2025

Huh, a closer look at the submission form doesn't seem to allow for the two-repo solution. So, fair, let's let this branch be the authoritative source for the paper, but let's not plan on merging it. Converting to draft to that end.

@inducer inducer marked this pull request as draft September 3, 2025 16:37
@inducer inducer changed the title Add initial JOSS paper JOSS paper Sep 3, 2025
@inducer
Copy link
Owner

inducer commented Sep 3, 2025

A quick random sample of other JOSS submissions seems to indicate that that's the common approach.

@inducer
Copy link
Owner

inducer commented Sep 3, 2025

cc @a-alveyblanc @thomasgibson @xywei for visibility.

@alexfikl
Copy link
Collaborator Author

alexfikl commented Sep 3, 2025

Huh, a closer look at the submission form doesn't seem to allow for the two-repo solution. So, fair, let's let this branch be the authoritative source for the paper, but let's not plan on merging it. Converting to draft to that end.

Yeah, the submission guidelines just sort of implicitly assume that it's the same repo (by mostly not talking about two repos in any way), but the submission form seems pretty clear cut that it wants a branch in the code's repo.

Marking this a draft and not merging it sounds good to me!

@inducer
Copy link
Owner

inducer commented Sep 3, 2025

#135 should fix the type failure. I'll rebase onto that, though we should probably stop doing that as soon as we submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants