-
Notifications
You must be signed in to change notification settings - Fork 7
JOSS paper #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
JOSS paper #134
Conversation
0f08356 to
68f92ff
Compare
|
The generated paper can be found in the workflow outputs: https://github.com/inducer/modepy/actions/runs/17404604638. It looks good to me! 😁 |
|
Thanks for getting this finished up! That said, I'm not sure the modepy repo is the right spot for it. I don't intend to "maintain" the paper in the same way I intend to maintain the docs or the code. Once it's finished, it's finished in my opinion, and the archival copy will live at JOSS. We can link to it, but IMO it's not great to include it here. |
My understanding of their submission documentation (from https://joss.readthedocs.io/en/latest/submitting.html#submission-process) is that the paper should be in the same repository somewhere. The submission form also has a We could make this a "branch" with no other history and just leave it there. Would that be ok? I mostly just made this PR to make sure that the build works, but I'm fine with not actually merging it into |
|
Reading their submission guidelines, I don't see anywhere that explicitly says that the paper has to be in the same repo as the code. And I'm not a huge fan of branch-is-separate-thing, it feels like that's holding git wrong. My read of the guidelines is that they want a repo (which IMO makes sense for change tracking) but aren't particular about which. As such, I think I'd be happiest if we could just move https://gitlab.tiker.net/papers/2025-modepy-joss someplace public. What do you think? |
|
Huh, a closer look at the submission form doesn't seem to allow for the two-repo solution. So, fair, let's let this branch be the authoritative source for the paper, but let's not plan on merging it. Converting to draft to that end. |
|
A quick random sample of other JOSS submissions seems to indicate that that's the common approach. |
|
cc @a-alveyblanc @thomasgibson @xywei for visibility. |
Yeah, the submission guidelines just sort of implicitly assume that it's the same repo (by mostly not talking about two repos in any way), but the submission form seems pretty clear cut that it wants a branch in the code's repo. Marking this a draft and not merging it sounds good to me! |
|
#135 should fix the type failure. I'll rebase onto that, though we should probably stop doing that as soon as we submit. |
This adds the JOSS paper to the
docfolder and includes a CI action to build it.NOTE: This PR will not be merged! It is a place to discuss the JOSS paper and make modifications during review.