Deprecate automatic flattening for tensor products #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'm supportive of this change. How come it's marked as draft? |
Collaborator
Author
Wasn't quite sure about adding that |
alexfikl
force-pushed
the
remove-tensor-product-flatten
branch
2 times, most recently
from
7226f10 to
37ea45f
Compare
alexfikl
force-pushed
the
remove-tensor-product-flatten
branch
from
37ea45f to
a27cd45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
.flatten()method to tensor products to recursively flatten them into simplices (mostly). The automatic flattening in the constructor is marked as deprecated.Fixes #126.