fix: new mypy errors due to numpy typing #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into how to fix the mypy errors from #103. It seems like the issue it's hitting is due to redefinitions, .e.g
is now a type error because of the different shapes of the arrays. I mostly "fixed" this by forcing the shape to be
tuple[int, ...]in all cases, but I imagine there's a nicer way to do it..@inducer Maybe worth just cherrypicking this into #103 if the mypy test pass, since the ruff tests may still fail.
cc @a-alveyblanc