Deprecate MPIMeshDistributor
#376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
deprecate-mesh-distributor
branch
from
e3f74f2 to
18c472a
Compare
majosm
approved these changes
May 3, 2023
Collaborator
majosm
left a comment
majosm
left a comment
There was a problem hiding this comment.
LGTM apart from Mypy issue. I think it's a bad type annotation in mpi4py and can be ignored; the tutorial for scatter uses None as well (see https://mpi4py.readthedocs.io/en/stable/tutorial.html -- search for "Scattering Python objects").
inducer
force-pushed
the
deprecate-mesh-distributor
branch
from
18c472a to
f85dece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #342.