Skip to content

also test production drivers #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthiasdiener wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

also test production drivers #224

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1498413
also test mirgecom examples in CI
matthiasdiener Mar 2, 2022
7494c85
reorder
matthiasdiener Mar 2, 2022
c441933
also test production
matthiasdiener Mar 2, 2022
3174e73
remove production test (won't work without emirge)
matthiasdiener Mar 2, 2022
8a6d232
also test production drivers
matthiasdiener Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,21 @@ jobs:
else
sed -i "/mpi4py/ d" requirements.txt
fi

build_py_project_in_conda_env
test_py_project
cd ..

if test "$DOWNSTREAM_PROJECT" = "mirgecom"; then
# Test main branch
examples/run_examples.sh ./examples

# Test production drivers
Copy link
Owner

@inducer inducer Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a separate CI job? mirgecom is already the longest job in grudge, I'm reluctant to make CI turnaround even more sluggish.

Copy link
Collaborator

@MTCam MTCam Mar 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe drop the downstream pytest (which takes a long time)? Running the examples (typically done within 10 minutes) will be enough and much faster. The examples won't work if MIRGE-Com is broken, and they will also fail if they get anything outside the accepted solution range.

Edit: I mean to suggest downstream examples is enough, full stop. No production testing either, as you suggested.

source .ci_support/production_testing_env.sh
source .ci_support/merge-install-production-branch.sh .
Copy link
Collaborator

@MTCam MTCam Mar 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down inside there there is a pip install -r requirements.txt after merging with production. Will that mess stuff up, or switch the grudge branch? Edit: Could just sed out the grudge part of it?

source .ci_support/production-drivers-install.sh .
source .ci_support/production-drivers-run.sh .
fi


# vim: sw=4