CROSSLINK-210 Add date time field support#39
Merged
JanisSaldabols merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds PostgreSQL date/datetime term parsing and query generation to the pgcql package, with accompanying unit and integration tests to validate SQL generation and execution.
Changes:
- Introduces a new
FieldDateTimefield type (NewFieldDate,WithOnlyDate) to generate SQL predicates and bindtime.Timearguments. - Extends parsing tests to cover date-only, datetime, and RFC3339-with-timezone inputs.
- Extends pgx integration tests to exercise
dateandtimestampcolumns and related CQL queries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pgcql/pg_field_datetime.go |
Adds the new date/datetime Field implementation and parsing logic. |
pgcql/pgcql_test.go |
Adds unit tests asserting SQL and bound args for date/datetime parsing. |
pgcql/pgx_test.go |
Adds integration coverage for date/timestamp columns and comparisons. |
Comments suppressed due to low confidence (2)
pgcql/pg_field_datetime.go:42
- The local variable name
numberholds atime.Timevalue fromparseTerm, which is misleading and makes the code harder to follow. Rename it to something time-related (e.g.,ts,dt,parsedTime) to match its actual type and intent.
number, err := f.parseTerm(sc.Term)
if err != nil {
pgcql/pg_field_datetime.go:20
NewFieldDate()constructs a type that (by default) accepts date and datetime inputs; the name suggests a date-only field. Consider renaming this constructor to something likeNewFieldDateTime()(and optionally adding a dedicatedNewFieldDate()that setsWithOnlyDate()), to avoid confusing API consumers and make the default behavior explicit.
func NewFieldDate() *FieldDateTime {
return &FieldDateTime{}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
adamdickmeiss
approved these changes
Mar 5, 2026
Contributor
adamdickmeiss
left a comment
There was a problem hiding this comment.
Looks good.
Perhaps allowing for only year to be given.
Also perhaps make support for date range with a 'within' operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.