Skip to content

[NOBUG]Fix PersistenceOptions comment to remove RPC #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longquanzheng merged 1 commit into from
Jul 7, 2025
Merged

[NOBUG]Fix PersistenceOptions comment to remove RPC #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/io/iworkflow/core/persistence/PersistenceOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@

@Value.Immutable
public abstract class PersistenceOptions {
// This option will enable caching persistence (data/search attributes) so that the readonly-RPC or GetDataAttributes API can
// This option will enable caching persistence (data/search attributes) so that GetDataAttributes and GetSearchAttributes API can
// support a much higher throughput on a single workflow execution.
// NOTES:
// 1. The read after write will become eventual consistent, unless set bypassCachingForStrongConsistency to true in RPC annotation
// 2. The caching is implemented by Temporal upsertMemo feature. Only iWF service with Temporal as backend is supporting this feature at the moment
// 3. It will extra cost as it will upsertMemo(WorkflowPropertiesModified event in the history) for write
// 4. Only useful for read-only RPC(no persistence.SetXXX API or communication API calls)
// 1. The caching is implemented by Temporal upsertMemo feature. Only iWF service with Temporal as backend supports this feature ATM.
// 2. It will cost extra action/event on updating data attribute, as iwf-server will upsertMemo(WorkflowPropertiesModified event in the history)
public abstract boolean getEnableCaching();

public static PersistenceOptions getDefault() {
Expand Down
Loading