feat(api-service): add experiment-level resource admission control#73
feat(api-service): add experiment-level resource admission control#73JacksonMei wants to merge 1 commit intomainfrom
Conversation
Implement three-tier admission (P0/P1/P2) with watermark-based throttling for cluster resource protection: - P0: known experiments always admitted - P1: new experiments gated by cluster utilization watermark and reserved capacity check - P2: requests missing required labels rejected (400) Includes Prometheus metrics, sliding-window peak tracking, response-capture middleware for instance-experiment mapping, and fallback record-only cleanup for unreachable nodes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust experiment-level resource admission control system to the API service. The primary goal is to enhance cluster stability and resource fairness by intelligently managing the creation of new environment instances. It prioritizes existing, known experiments, while new experiments are admitted only if cluster utilization is below a configurable watermark and sufficient capacity is reserved. Additionally, it enforces mandatory labels for requests and provides comprehensive metrics for monitoring the system's behavior, ensuring a more resilient and predictable environment for running experiments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Implement three-tier admission (P0/P1/P2) with watermark-based throttling for cluster resource protection:
Includes Prometheus metrics, sliding-window peak tracking, response-capture middleware for instance-experiment mapping, and fallback record-only cleanup for unreachable nodes.