Skip to content

feat(api-service): add experiment-level resource admission control#73

Draft
JacksonMei wants to merge 1 commit intomainfrom
jun/expr
Draft

feat(api-service): add experiment-level resource admission control#73
JacksonMei wants to merge 1 commit intomainfrom
jun/expr

Conversation

@JacksonMei
Copy link
Copy Markdown
Collaborator

Implement three-tier admission (P0/P1/P2) with watermark-based throttling for cluster resource protection:

  • P0: known experiments always admitted
  • P1: new experiments gated by cluster utilization watermark and reserved capacity check
  • P2: requests missing required labels rejected (400)

Includes Prometheus metrics, sliding-window peak tracking, response-capture middleware for instance-experiment mapping, and fallback record-only cleanup for unreachable nodes.

Implement three-tier admission (P0/P1/P2) with watermark-based
throttling for cluster resource protection:

- P0: known experiments always admitted
- P1: new experiments gated by cluster utilization watermark
  and reserved capacity check
- P2: requests missing required labels rejected (400)

Includes Prometheus metrics, sliding-window peak tracking,
response-capture middleware for instance-experiment mapping,
and fallback record-only cleanup for unreachable nodes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust experiment-level resource admission control system to the API service. The primary goal is to enhance cluster stability and resource fairness by intelligently managing the creation of new environment instances. It prioritizes existing, known experiments, while new experiments are admitted only if cluster utilization is below a configurable watermark and sufficient capacity is reserved. Additionally, it enforces mandatory labels for requests and provides comprehensive metrics for monitoring the system's behavior, ensuring a more resilient and predictable environment for running experiments.

Highlights

  • Three-Tier Admission Control: Implemented a three-tier admission control system (P0/P1/P2) to manage resource allocation for experiments.
  • Watermark-Based Throttling: Introduced watermark-based throttling to gate new experiments (P1) based on cluster utilization and reserved capacity.
  • Required Label Enforcement: Requests missing required labels (P2) are now rejected with a 400 error, ensuring metadata consistency.
  • Observability and Metrics: Integrated Prometheus metrics for admission decisions, reserved capacity, experiment counts, and cluster utilization.
  • Fallback Cleanup Mechanism: Added a fallback record-only cleanup mechanism for instances on unreachable nodes, preventing resource leaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant