PHP 8 and TYPO3 related updates #17#23
Open
josefglatz wants to merge 10 commits intoin2code-de:mainfrom
Open
Conversation
josefglatz
changed the title
Contributor
|
Thx for your work Josef, I just added some comments to the code itself when you have some time for me :) |
Author
|
@einpraegsam Hey Alex, where can I find your comments? |
einpraegsam
requested changes
Oct 11, 2022
| * @return void | ||
| */ | ||
| public function showAction() | ||
| public function showAction(): ResponseInterface |
Contributor
There was a problem hiding this comment.
Just a question: Is this still ok for TYPO3 10? I'm asking because otherwise, we have to adjust the requirements.
Author
There was a problem hiding this comment.
If it's ok I would leave it as-is and therefore remove the support for TYPO3 10. Since the extension looks like it's feature complete and TYPO3 v12 is coming I would suggest to support only v11 – if OK for you Alex!
I will update therefore the proper constraints.
Contributor
There was a problem hiding this comment.
Yes, dropping support for 10 is fine also for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.