Sending unique ping data to ensure response is related to request#55
Open
digartner wants to merge 1 commit intoimportcjj:mainfrom
Open
Sending unique ping data to ensure response is related to request#55digartner wants to merge 1 commit intoimportcjj:mainfrom
digartner wants to merge 1 commit intoimportcjj:mainfrom
Conversation
Contributor
Author
|
Related to #28 According to that issue, some redis connections become "corrupted" due to time outs. Subsequent calls to |
Collaborator
|
@digartner could you change this to point to the new main and then we can merge it in. |
aqrln
reviewed
Jan 25, 2025
| async fn check(&self, mut conn: Self::Connection) -> Result<Self::Connection, Self::Error> { | ||
| let pong: String = redis::cmd("PING").query_async(&mut conn).await?; | ||
| if pong.as_str() != "PONG" { | ||
| let ping = self.ping_count.fetch_add(1, Ordering::SeqCst); |
Collaborator
There was a problem hiding this comment.
Suggested change
| let ping = self.ping_count.fetch_add(1, Ordering::SeqCst); | |
| let ping = self.ping_count.fetch_add(1, Ordering::Relaxed); |
no need for SeqCst here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.