Add uploadPreset support for Cloudinary upload presets#1
Open
ryanwoodcox wants to merge 1 commit intoimaxisXD:mainfrom
Open
Add uploadPreset support for Cloudinary upload presets#1ryanwoodcox wants to merge 1 commit intoimaxisXD:mainfrom
ryanwoodcox wants to merge 1 commit intoimaxisXD:mainfrom
Conversation
Add the uploadPreset parameter across all upload flows to enable Cloudinary upload presets with signed uploads. Upload presets allow pre-configured settings (folder, transformations, moderation, etc.) to be enforced server-side. Changes: - Add uploadPreset to CloudinaryUploadOptions interface - Include upload_preset in signature generation for signed uploads - Add uploadPreset to upload and generateUploadCredentials actions - Update client UploadOptions and DirectUploadOptions interfaces - Add uploadPreset to makeCloudinaryAPI validators and return types - Update CloudinaryAPI type in React hooks - Add tests for uploadPreset parameter acceptance - Document upload options including uploadPreset in README
Author
|
@imaxisXD , could you please have a look? |
Author
Any thoughts? |
Owner
|
I am still not sure whether we need this. |
Owner
|
This should be done by the user in there db |
Author
Could you be more specific on how one can specify a Cloudinary upload preset when uploading images using this package? Also, this proposed addition has minimal impact on the package. Is there a concern about this change adding risks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the uploadPreset parameter across all upload flows to enable Cloudinary upload presets with signed uploads. Upload presets allow pre-configured settings (folder, transformations, moderation, etc.) to be enforced server-side.
Changes: