Skip to content

Enable signature registration in other signatures for cross-task execution #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yedidyakfir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable signature registration in other signatures for cross-task execution #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f2a43
[support-to-invoke-task-for-same-worker] - check all chain params are…
YedidyaHKfir Dec 18, 2025
cf33cf1
[support-to-invoke-task-for-same-worker] - send data via kwargs, not …
YedidyaHKfir Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration/hatchet/assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,11 @@ def assert_chain_done(
chain_tasks = [task_map[task_id] for task_id in chain_signature.tasks]
assert_tasks_in_order(wf_by_signature, chain_tasks)
output_value = None
input_params = {}
for chain_task_id in chain_signature.tasks:
input_params = chain_signature.kwargs.copy()
task = task_map[chain_task_id]
if output_value:
input_params = {task.return_value_field(): output_value}
input_params |= {task.return_value_field(): output_value}
task_wf = _assert_task_done(chain_task_id, wf_by_signature, input_params)
output_value = task_wf.output["hatchet_results"]

Expand Down
4 changes: 3 additions & 1 deletion tests/integration/hatchet/chain/test__chain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import pytest

import mageflow
from hatchet_sdk.runnables.types import EmptyModel
from mageflow.signature.model import TaskSignature
from tests.integration.hatchet.assertions import (
assert_redis_is_clean,
Expand Down Expand Up @@ -35,7 +36,7 @@ async def test_chain_integration(
hatchet_client_init.redis_client,
hatchet_client_init.hatchet,
)
message = ContextMessage(base_data=test_ctx)
message = EmptyModel()

signature2 = await mageflow.sign(task2, success_callbacks=[sign_callback1])
chain_success_error_callback = await mageflow.sign(error_callback)
Expand All @@ -48,6 +49,7 @@ async def test_chain_integration(
[sign_task1, signature2.key, task3],
success=success_chain_signature,
)
await chain_signature.kwargs.aupdate(base_data=test_ctx)
chain_tasks = await TaskSignature.afind()

await chain_signature.aio_run_no_wait(message, options=trigger_options)
Expand Down
Loading