v0.0.5 #10
v0.0.5 #10
Conversation
Add CodeQL analysis workflow configuration
…op' into feature/add-ttl-for-signatures
…task execution timeouts
…arm item is done to fill concurrency
…t extremley large workflows with persistent DB
…function to fill running tasks with
…arm fill the tasks concurrency
…use correct method to check who call whom
…r-swarm-item-done [publish-many-after-swarm-item-done] - added test for checking the swarm fill the tasks concurrency
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This pull request bumps the version to 0.0.5 and includes repository ownership transfer, a new TTL feature for task signatures, improved swarm concurrency handling, and comprehensive CI/CD workflow improvements.
Key Changes:
- Added automatic TTL (24 hours) for task signatures to prevent Redis memory buildup
- Refactored swarm task execution to use
fill_running_tasks()for better concurrency control - Migrated repository from "yedidyakfir" to "imaginary-cherry" GitHub organization
- Enhanced CI/CD with branch protection rules and improved test matrix coverage
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump to 0.0.5, author name change, repository URL updates, rapyer dependency upgrade |
| mageflow/signature/model.py | Added TTL configuration (24 hours), updated import organization, changed rapyer.get to rapyer.aget |
| mageflow/swarm/model.py | Added fill_running_tasks() method, removed pop_task_to_run(), improved concurrency handling |
| mageflow/swarm/workflows.py | Updated to use new fill_running_tasks() instead of individual task popping |
| mageflow/chain/model.py | Updated to use rapyer.aget instead of rapyer.get |
| mageflow/visualizer/data.py | Fixed spelling errors: sigantures → signatures, updated to use rapyer.aget |
| mageflow/init.py | Added retries and execution timeouts to Hatchet tasks for better reliability |
| tests/unit/swarm/test_swarm.py | Added comprehensive tests for fill_running_tasks() functionality |
| tests/integration/test_redis_ttl.py | New test file verifying TTL configuration for signatures, chains, and swarms |
| tests/integration/hatchet/test_task_models.py | New test verifying HatchetTaskModel has no TTL |
| tests/integration/hatchet/swarm/test__swarm.py | Added integration tests for swarm concurrency with success and failure scenarios |
| tests/integration/hatchet/assertions.py | Added helper functions for finding sub-calls and mapping workflows |
| tox.ini | Major restructure to support multiple Python and Hatchet SDK versions with matrix testing |
| .github/workflows/ci.yml | Added branch protection validation, migrated to tox-based testing |
| .github/workflows/publish.yml | Restructured to trigger on CI completion, auto-create release tags |
| .github/workflows/release.yml | New workflow for creating GitHub releases from tags |
| .github/workflows/coverage.yml | Updated to trigger after CI completion |
| .github/workflows/codeql.yml | New CodeQL security scanning workflow |
| poetry.lock | Updated dependencies (black, asgiref, fakeredis, hatchet-sdk, pydantic, psutil, redis, etc.) |
| docs/roadmap.md | Added enterprise scale & persistence section with persistent DB architecture |
| README.md, docs/index.md, docs/setup.md, mkdocs.yml | Updated all repository URLs to new organization |
| LICENSE | Updated copyright holder to "imaginary-cherry" |
| CHANGELOG.md | Added release notes for version 0.0.5 |
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:18
- The publish workflow will fail when trying to create and push tags because the job only has
contents: readpermission. To create and push tags, the job needscontents: writepermission. Update the permissions section to include write access.
permissions:
id-token: write # Required for trusted publishing
contents: read
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| jobs: | ||
| create-github-release: | ||
| needs: check-tests |
There was a problem hiding this comment.
The workflow references a job 'check-tests' that doesn't exist in this file. The 'create-github-release' job depends on 'check-tests' via 'needs: check-tests', but this job is not defined anywhere in the release.yml workflow. This will cause the workflow to fail when triggered by a tag push.
| needs: check-tests |
| ``` | ||
|
|
||
| **Technical Challenges:** | ||
| - 🔄 **Cache Cohekrency** - Maintain consistency between Redis and persistent DB |
There was a problem hiding this comment.
Spelling error: "Cohekrency" should be "Coherency".
| - 🔄 **Cache Cohekrency** - Maintain consistency between Redis and persistent DB | |
| - 🔄 **Cache Coherency** - Maintain consistency between Redis and persistent DB |
| import asyncio | ||
|
|
||
| import pytest | ||
| from hatchet_sdk.clients.rest import V1TaskStatus |
There was a problem hiding this comment.
Import of 'V1TaskStatus' is not used.
| from hatchet_sdk.clients.rest import V1TaskStatus |
| @@ -0,0 +1,55 @@ | |||
| import pytest | |||
| import pytest_asyncio | |||
There was a problem hiding this comment.
Import of 'pytest_asyncio' is not used.
| import pytest_asyncio |
| @@ -0,0 +1,28 @@ | |||
| import asyncio | |||
| import pytest | |||
| import pytest_asyncio | |||
There was a problem hiding this comment.
Import of 'pytest_asyncio' is not used.
| import pytest_asyncio |
No description provided.