fix: Axis labels disappearing due to incorrect padding calculation in title filtering#2080
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 93.00% 93.01% +0.01%
==========================================
Files 50 50
Lines 3917 3924 +7
==========================================
+ Hits 3643 3650 +7
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Good catch. Thanks for the contribution. Are you able to add a test case for this fix? |
|
Added a test. edit: By the way, there is a theoretical edge case that I did not test for or fix - if you set a reserved space larger than the (correct) related chart side, exceptions occur. But I guess that is user fault and would result in a stupid (not visible) chart anyways. |
|
Nice, thanks so much! |
Description
This fixes issue #2078, #1963
The box that checks if titles should be drawn was calculated incorrectly, not taking different padding on different axis (and rotation) into account. If a "reserved space" property was larger than the height/width, it made the other titles disappear.
The fix is pretty straight forward in my opinion: Take these things into account.
Checklist
///.example.Breaking Change?
Related Issues
Fixes #2078