Skip to content

Fix: Replace Path.combine with angular spacing in pie chart#2079

Open
PieroSoria wants to merge 13 commits intoimaNNeo:mainfrom
PieroSoria:main
Open

Fix: Replace Path.combine with angular spacing in pie chart#2079
PieroSoria wants to merge 13 commits intoimaNNeo:mainfrom
PieroSoria:main

Conversation

@PieroSoria
Copy link
Copy Markdown

Description

This PR changes how section spacing is handled in PieChart.

Instead of using Path.combine (which causes rendering issues),
it reduces the sweep angle of each section to create real spacing.

This avoids overlap and visual glitches.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///.
  • I have updated/added relevant examples in example.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@PieroSoria
Copy link
Copy Markdown
Author

fix: resolve merge conflicts and improve pie chart section spacing

@PieroSoria PieroSoria changed the title fix: add real spacing between pie chart sections Fix: add real spacing between pie chart sections Mar 25, 2026
@PieroSoria PieroSoria changed the title Fix: add real spacing between pie chart sections Add real spacing between pie chart sections Mar 25, 2026
@PieroSoria PieroSoria changed the title Add real spacing between pie chart sections Fix: Replace Path.combine with angular spacing in pie chart Mar 25, 2026
@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Apr 10, 2026

We're adding some changes in the PieChart painter in this PR.
Can you please wait until we add those changes? Because I'm pretty sure you're gonna get some conflicts

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Apr 15, 2026

Alright, #2004 has just merged.
Can you please update your code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants