Skip to content

Feat/prevent curve over shooting xy variants#1981

Closed
bcheidemann wants to merge 2 commits intoimaNNeo:mainfrom
bcheidemann:feat/preventCurveOverShooting-xy-variants
Closed

Feat/prevent curve over shooting xy variants#1981
bcheidemann wants to merge 2 commits intoimaNNeo:mainfrom
bcheidemann:feat/preventCurveOverShooting-xy-variants

Conversation

@bcheidemann
Copy link
Copy Markdown

@bcheidemann bcheidemann commented Aug 29, 2025

Depends on #1980

preventCurveOverShooting: false

Screenshot 2025-08-29 at 16 23 49

preventCurveOverShooting: true

Screenshot 2025-08-29 at 16 22 24

preventCurveOverShootingX: true (this PR)

Screenshot 2025-08-29 at 16 23 14

@bcheidemann
Copy link
Copy Markdown
Author

I hacked this together to see if it would be useful. Seems like it might be. If so, happy to implement any feedback and add tests 👍

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Oct 25, 2025

We have a new implementation of a curved line,
Can you please check if that already solves your issue or not?
It's not merged yet, but you can take a look at it here:
#2000

@bcheidemann
Copy link
Copy Markdown
Author

We have a new implementation of a curved line, Can you please check if that already solves your issue or not? It's not merged yet, but you can take a look at it here: #2000

@imaNNeo thanks for sharing this. The LineChartCubicMonotoneCurve implementation produces much better results for me on this branch.

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Feb 25, 2026

@imaNNeo thanks for sharing this. The LineChartCubicMonotoneCurve implementation produces much better results for me on this branch.

So do you want to close your PR if LineChartCubicMonotoneCurve already works well?

@bcheidemann
Copy link
Copy Markdown
Author

@imaNNeo yes, apologies for keeping this open. Meant to close it and forgot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants