Reset column information in-between each migration#251
Open
caius wants to merge 1 commit intoilyakatz:mainfrom
Open
Reset column information in-between each migration#251caius wants to merge 1 commit intoilyakatz:mainfrom
caius wants to merge 1 commit intoilyakatz:mainfrom
Conversation
Writing to a table in one migration, amending the columns in another migration then trying to write to the same table blows up when all the migrations are in the same run. Resetting the column information on all models between migrations doesn't add much time at all, but avoids that being an issue.
Author
|
@ilyakatz is there any appetite for accepting this patch upstream please? |
Owner
Collaborator
|
Hey @caius -- we're in the middle of refactoring how migrations are run and will look to incorporate this after the dust settles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into an issue where having the following run in the same
rake db:migrate:with_dataprocess caused an issue:We ended up needing to call
ActiveRecord::Base#reset_column_information)as documented in the rails guides between amending the table and trying to write to it in the same ruby process. (If you split any of the above migration files into different runs, this issue goes away.)Rather than have to remember to call reset_column_information every time we either amend a table or try to write to a table in either schema or data migrations respectively, lets just call it for all models before we run either migration. It's a very low cost call from testing and migrations aren't usually run all that often (certainly compared to web requests).