feat(monitoring): align observability stack with issue #10 acceptance#195
Open
vildanden-ai wants to merge 1 commit intoillbnm:masterfrom
Open
feat(monitoring): align observability stack with issue #10 acceptance#195vildanden-ai wants to merge 1 commit intoillbnm:masterfrom
vildanden-ai wants to merge 1 commit intoillbnm:masterfrom
Conversation
|
👋 Hi @illbnm! Checking in on the Observability Stack PR review status. PR Summary:
Ready for any feedback or adjustments. Appreciate your time! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the observability stack with issue #10 acceptance criteria for:
What changed
1) Compose/services and pinned versions
stacks/monitoring/docker-compose.ymllatest)2) Prometheus scrape targets
config/prometheus/prometheus.ymlto include required jobs:cadvisornode-exportertraefikauthentiknextcloudgiteaprometheus3) Alert rules split exactly as required
config/prometheus/alerts/host.ymlconfig/prometheus/alerts/containers.ymlconfig/prometheus/alerts/services.ymlconfig/prometheus/rules/homelab.yml4) Grafana provisioning + dashboards
config/grafana/dashboards/:logs.jsonwith UIDlogsso Explore shortcut path/d/logs/logsexists5) Logs/traces/retention
/var/log/syslogconfig/tempo/tempo-config.yml6) Alertmanager → ntfy
config/alertmanager/alertmanager.yml7) Uptime Kuma automation
scripts/uptime-kuma-setup.shscripts/uptime-kuma-setup.py8) OIDC role mapping and docs/env
homelab-admins-> Adminhomelab-users-> Viewer.env.exampleandstacks/monitoring/.env.examplestacks/monitoring/README.mdwith acceptance mapping and validation stepsAcceptance criteria mapping
Validation run (in CI-less sandbox)
Static/local checks completed:
python3 -m py_compile scripts/uptime-kuma-setup.pypassedbash -n scripts/uptime-kuma-setup.shpassedRuntime blockers in this environment:
docker: command not found), so live E2E checks (docker compose up, target UP checks, stress-trigger alert, HTTP 200 endpoint probes) could not be executed here.Tooling note required by issue
Generated/reviewed with: claude-opus-4-6
Codex review
I performed a GPT-5.3 Codex cross-check for:
No unresolved critical findings are intentionally left in this PR.
If maintainers want, I can follow up with host-run proof logs (
docker compose ps, Prometheus Targets UP screenshot, and alert fire/resolve evidence) once executed on a Docker-enabled host.