Fix off-by-one errors in board and promotion click mapping#7
Merged
Conversation
squareFromMouse assumed the board's top cell was at terminal row 0, but puzzle and replay screens render a title + blank line first, placing the board at row 2. Clicks below the top row of each square spilled into the square below. Add SetBoardOriginY so screens declare the board's vertical origin, and translate the mouse y by it. handlePromoClick had the same class of bug: it hit-tested the promotion piece cells at promoPopupY+2, but the cells render at promoPopupY+1 (the row right after the "Promote pawn:" label). This rejected the top piece row and accepted the key-label row below the pieces. Fix to +1. Add regression tests for both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two vertical off-by-one bugs in mouse click handling where the click-to-coordinate math didn't match the actual rendered layout.
Square clicking
squareFromMouseassumed the board's top cell sat at terminal row 0. That holds for the live game screen, but the puzzle and replay screens render a title + blank line first, placing the board at row 2. The missing offset meant clicks below the top row of each square spilled into the square below it.Fix: add
SetBoardOriginYso each screen declares the board's vertical origin (set to2in puzzle/replay; the live game keeps the0default), and translate the mouseyby it.Promotion popup
handlePromoClickhit-tested the promotion piece cells atpromoPopupY + 2, but the cells render atpromoPopupY + 1— the row right after the"Promote pawn:"label. This rejected clicks on the top piece row (the queen) and wrongly accepted the key-label row below the pieces. Fixed to+1.Testing
go test ./...— all greenTestLocalMoveInput_HandleMsg_BoardOriginY_OffsetsClickTestLocalMoveInput_HandlePromoClick_TopPieceRowSelectsQueenTestLocalMoveInput_HandlePromoClick_LabelRowIsNotAPiece🤖 Generated with Claude Code