Open
Conversation
Folks wanting JSON5 handling for their data can add that in their application layer. This removes the one dependency this project had, making it much more sustainable, simpler, and faster. Huzzah!
kle.Serial.deserialize(JSON.parse(`[]`)) is equivalent now.
|
+1 to this; seems like a good candidate for a major version bump as well so folks who were dependent on |
|
i think the rational here was to avoid typing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON5 is cool for what it is, but not sure it's a mandatory requirement for this package--and having it "in the way" was meaning lots of build overhead to use kle-serial in a browser.
Consequently, these two commits...
.parse()method altogether as it can (should?) be done at an application layer if/when needed (+/- JSON5 support if that's wanted).This then focuses this library on just deserialization. Huzzah! 😀
Thanks for building this and KLE!
🎩