FILLMTR (SEPT17) [Python]#195
FILLMTR (SEPT17) [Python]#195abhigyank wants to merge 7 commits intoiiitv:masterfrom abhigyank:master
Conversation
|
Hi! Thanks for contributing to this repository. |
|
Hey, I didn't understand what you posted. I haven't changed any of the files that are shown in the error. |
|
@abhigyank Don't get frightened over such long messages those are auto-generated gitmate issues, from what I can see you need to resolve conflicts and update your repo, thats it. 😉 |
|
@Monal5031 please review and merge. |
2017/SEPT/SEPT17/FILLMTR/FILLMTR.py
Outdated
| print "no" | ||
|
|
||
| if __name__ == '__main__': | ||
| main() No newline at end of file |
There was a problem hiding this comment.
Add a new line at the end.
|
@Monal5031 I request you not to delete, gitmate comments, as it will only raise coala issues. |
|
@aashutoshrathi I don't see travis in the check list, have you deactivated it? |
|
@abhigyank Can make some changes and repush? Inorder to activate the travis build, so we can see what is causing the tests to fail. |
|
@Monal5031 What changes can I make? Maybe you can check the Travis logs or see in the next PR. |
|
@abhigyank You can add spaces around binary operator, like |
|
@aashutoshrathi Maybe you should squash and merge now. |
|
@abhigyank Sorry for late reply but I can still see three issues in travis log for your PR. |
|
ping @abhigyank Its been 5 days since this PR was last updated, please update it. |
|
@Monal5031 Check now please. |
| ans = 1 | ||
| for i in range(n): | ||
| good.append('a') | ||
| good.append('a') |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py
+++ b/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py
@@ -62,7 +62,7 @@
else:
print "no"
-
+
if __name__ == '__main__':
main()
| good.append('a') | ||
| for i in range(q): | ||
| a = map(int, raw_input().split()) | ||
| queries.append(a) |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py
+++ b/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py
@@ -65,4 +65,3 @@
if __name__ == '__main__':
main()
- |
@aashutoshrathi @Monal5031 All tests passed. Squash and merge PR. |
|
Any reason why this hasn't been merged yet? |
|
@abhigyank Please resolve conflicts |
Fixes #189
Problem Code (Contest Code) [Language].