Allow creation of presets from existing install via Content Menu UI by misaochan · Pull Request #634 · iiab/iiab-admin-console

misaochan · 2026-03-19T12:04:04Z

Part 2 (final part), closes #623 . Also resolves #624 and #626 . Tested multiple scenarios as seen below, running on VirtualBox with Ubuntu 24.04.4.

The Content Menu now has a "Create a Content Collection" panel that allows users to create a preset from their existing install, including Kolibri channels. All the fields in preset.json can be filled in, except for size_in_gb and last_modified, which are computed automatically.

Test scenario with successful creation and import

Clicking "Create" triggers mk-preset.py. For instance, in this test case I am creating a preset after downloading the PointB Kolibri channel.

In Install Content > Quick Pick, the user will then see their new preset in the list.

And when they import that preset, the PointB Kolibri channel "channel_id": "254f1b384c2551ed80ada423449212a1" is automatically downloaded.

Test scenario where the preset name filled in by the user is the same as a supplied preset name.

Creation of the preset is blocked.

Test scenario where the preset name filled in by the user is the same as an existing preset name, but NOT a supplied preset name.

A warning is shown and the user can choose to overwrite if desired.

…ecks for overwrite

misaochan · 2026-03-20T10:31:50Z

@tim-moody Ready for review. :)

chapmanjacobd · 2026-03-20T14:33:41Z

+def get_kolibri_lang():
+    kolibri_db = '/library/kolibri/db.sqlite3'
+    conn = sqlite3.connect(kolibri_db)
+    cur = conn.execute('SELECT language_id FROM device_devicesettings LIMIT 1')


This is per device and not per channel?

Yup, per device.

…u items with en-kolibri

misaochan · 2026-03-24T19:21:46Z

Removed all the kalite empty objects in content.json and their references in install_presets(), and replaced kalite menu items with their kolibri counterparts as requested. Tested fr-school preset:

misaochan · 2026-03-24T19:25:40Z

    map_cmd_info = cmd_info
    map_list = content['maps']
    for map in map_list:
+        map_cmd_info = cmd_info


Fixes a pre-existing bug where the maps loop crashes if pseudo_cmd_handler returns None for any map entry. Noticed it because fr-school had multiple maps and I ran a re-installation.

tim-moody · 2026-03-24T19:33:56Z

zim_list = content['zims']
module_list = content['modules'] # service is web server which is always installed
map_list = content['maps']
kalite_vars = content['kalite']

So is this problem there for all content types and removing kalite {} was a mistake?

misaochan · 2026-03-24T19:42:20Z

So kalite_vars doesn't actually do anything now, which is why I removed it. The problem does exist for all content types though. It can be fixed by:

zim_list = content.get('zims', [])
module_list = content.get('modules', [])
map_list = content.get('maps', [])

Happy to add those to this PR as well if you want.

tim-moody · 2026-03-24T21:15:01Z

go ahead and make those changes

misaochan · 2026-03-25T10:57:35Z

@tim-moody All done. Tested by installing en-school, which has quite a few ZIMs, all jobs scheduled successfully.

tim-moody · 2026-03-26T18:04:15Z

merged against master

misaochan · 2026-03-26T18:27:29Z

Thanks for merge! Can we close the related issues? #623 #624 #626 The automatic closure via PR doesn't work as the master merge was done directly from my branch instead of from the PR.

tim-moody · 2026-03-26T18:34:43Z

yes. I think I messed up and did not merge wip-01. In any event I outsmarted myself, so let's just work on master. I believe master is up to date

…

On Thu, Mar 26, 2026 at 2:27 PM Josephine Lim ***@***.***> wrote: *misaochan* left a comment (iiab/iiab-admin-console#634) <#634?email_source=notifications&email_token=ABLKNCZ632C3RIZS2NR2IML4SVZCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTG4ZDOMZTGE22M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4137273315> Thanks for merge! Can we close the related issues? #623 <#623> #624 <#624> #626 <#626> The automatic closure via PR doesn't work as the master merge was done directly from my branch instead of from the PR. — Reply to this email directly, view it on GitHub <#634?email_source=notifications&email_token=ABLKNCZ632C3RIZS2NR2IML4SVZCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTG4ZDOMZTGE22M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4137273315>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLKNC33KMDW2DXQT6W3U234SVZCRAVCNFSM6AAAAACWX3FMFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZXGI3TGMZRGU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

misaochan · 2026-03-26T18:36:33Z

Haha all good! Yeah, I'll submit my future PRs to master. :)

tim-moody · 2026-03-26T18:42:02Z

Keep an eye out for anything I didn't merge.

…

On Thu, Mar 26, 2026 at 2:36 PM Josephine Lim ***@***.***> wrote: *misaochan* left a comment (iiab/iiab-admin-console#634) <#634?email_source=notifications&email_token=ABLKNC45RAM2B3PR6A6GOPD4SV2EPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTG4ZTENZTGM3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4137327336> Haha all good! Yeah, I'll submit my future PRs to master. :) — Reply to this email directly, view it on GitHub <#634?email_source=notifications&email_token=ABLKNC45RAM2B3PR6A6GOPD4SV2EPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTG4ZTENZTGM3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4137327336>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLKNC4C6DA75HLO6GEDSN34SV2EPAVCNFSM6AAAAACWX3FMFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZXGMZDOMZTGY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

misaochan · 2026-03-26T18:46:43Z

You should have everything, I think - I can see that my whole branch was merged in. I'll let you know if I find any issues.

misaochan · 2026-03-26T18:51:00Z

Oh, I don't have permissions to close the issues btw.

misaochan added 3 commits March 11, 2026 16:30

Add Kolibri to mk-preset.py and install it

780ff23

Add Create a Content Collection panel to Install Content menu, add ch…

d499d35

…ecks for overwrite

Comments and formatting

5fc9433

chapmanjacobd approved these changes Mar 20, 2026

View reviewed changes

misaochan added 3 commits March 24, 2026 18:05

Remove all kalite empty objects from content.json. Replace kalite men…

3c94987

…u items with en-kolibri

Change es and fr presets to use correct menu defs

153e689

Remove kalite to fix errors

b619662

misaochan commented Mar 24, 2026

View reviewed changes

Use content.get() to handle missing keys

8dbff52

tim-moody closed this Mar 26, 2026

holta mentioned this pull request Mar 26, 2026

Kolibri part2 #638

Merged

Conversation

misaochan commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test scenario with successful creation and import

Test scenario where the preset name filled in by the user is the same as a supplied preset name.

Test scenario where the preset name filled in by the user is the same as an existing preset name, but NOT a supplied preset name.

Uh oh!

misaochan commented Mar 20, 2026

Uh oh!

chapmanjacobd Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

misaochan Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

misaochan commented Mar 24, 2026

Uh oh!

misaochan Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

tim-moody commented Mar 24, 2026

Uh oh!

misaochan commented Mar 24, 2026

Uh oh!

tim-moody commented Mar 24, 2026

Uh oh!

misaochan commented Mar 25, 2026

Uh oh!

tim-moody commented Mar 26, 2026

Uh oh!

misaochan commented Mar 26, 2026

Uh oh!

tim-moody commented Mar 26, 2026 via email

Uh oh!

misaochan commented Mar 26, 2026

Uh oh!

tim-moody commented Mar 26, 2026 via email

Uh oh!

misaochan commented Mar 26, 2026

Uh oh!

misaochan commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

misaochan commented Mar 19, 2026 •

edited

Loading