Custom properties UI#369
Open
chapmanjacobd wants to merge 5 commits into
Open
Conversation
Member
|
cc @tim-moody |
Collaborator
Member
Author
|
hmm that's interesting 🤔 I'll try making a patch |
04896a4 to
6e79839
Compare
Member
Author
|
custom rating properties were being saved/computed as strings, so that broke some things... you might need to create a new database or try deleting the custom column before trying again |
Collaborator
|
I'm looking for a better way to test this. Now internal server error kicks in on clicking "Edit metadata". https://lrn2.org/live/admin/book/1118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




should be able to close #368
now you can have multiple Rating-style columns too!
needs testing! @GarbaJohnAshifa (the UI to add new fields is in the Admin console)