Fix octoprint versioning by checking python version#54
Open
gravfu wants to merge 5 commits intoihrapsa:mainfrom
Open
Fix octoprint versioning by checking python version#54gravfu wants to merge 5 commits intoihrapsa:mainfrom
gravfu wants to merge 5 commits intoihrapsa:mainfrom
Conversation
Author
|
I made this patch without having an owrt os under my hands. Please consider to review my work on a working card with openwrt inside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The goal of this pull request is to consider that people could have different versions of python3 depend on their firmware.
So I made an adjustment to check which version of Octoprint people will have to install.
This should theoretically fix #42 #43 #46 #47 #50