chore(core): drop fixtures from published npm package#33
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixtures (
packages/core/fixtures/*.json) were shipped with the npm tarball but never reachable from consumer code:exportsonly declared the root entry, soimport x from '@formhaus/core/fixtures/basic-form.json'fails under strict ESM (Node 16+, Vite production, Next.js prod build) withERR_PACKAGE_PATH_NOT_EXPORTED. Two options were on the table:./fixtures/*.jsontoexports, keep shipping themThis PR takes (2). Reasons:
@formhaus/core/fixtures/basic-form.json.dispute-form.json→ bumps anyone using it.@formhaus/core/fixtures/basic-form.jsonwas broken in production builds anyway. Now it shows an inline definition (which is what the README and every other docs page already do).Changes
packages/core/package.json: removed"fixtures"fromfiles. Tarball now containsdist/,package.json,README.md,LICENSEonly.docs/guide/index.md: Quick Start now uses an inline definition matching root README's style..changeset/drop-fixtures-from-npm.md: patch on@formhaus/core.Fixtures still live in the repo at
packages/core/fixtures/for the playground and reference. They're just not part of the published package.Verifying