-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix css relative url paths #3073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
akrherz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
|
I can't tell if the ci failure is due to this change, please let me know if I need to fix something here. |
|
Our CI is notoriously unstable, sadly. It hasn't anything to do with your fix. I've restarted the build, which gives it a good chance of succeeding this time. Does your fix actually improve something? Is there a visual improvement, or a functional one? I'm wondering if those files are used at all. |
|
Same, I haven't noticed any changes in the UI |
|
Maybe we should take it out then, rather than 'fix' it? |
|
I will come back to this in a while, feel free to do a quick fix (removal) right away. |
|
Does openfire have some selenium/playwright or other ui test setup? |
No, it does not have any of that kind of automated testing. |
In the setup the were showing up 404 when I opened the console.