i18n: remove obsolete strings #3052
Open
+67
−500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
requested changes
Nov 30, 2025
Member
Fishbowler
left a comment
Fishbowler
left a comment
There was a problem hiding this comment.
Thanks for going through all of this. There's a bunch of great catches in here!
There's also:
- TLS accidentally misspelled as TSL throughout
- A few English strings that I've got opinions on :)
stokito
force-pushed
the
ssl
branch
2 times, most recently
from
cc4b7d9 to
1d673f2
Compare
stokito
commented
Dec 11, 2025
Contributor
Author
|
@Fishbowler please merge when you'll have a minute |
Fishbowler
approved these changes
Jan 3, 2026
Member
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in a few places the SSL is mentioned while it should be TLS. So I removed mention of the SSL.
I checked the strings nearby and turned out that many of them aren't used anymore.
For example:
ssl.settings.client.label_notrequiredis not used anywhere https://github.com/search?q=org%3Aigniterealtime%20%22ssl.settings.client.label_notrequired%22&type=codeAlso IntelliJ marked a few grammar errors (missing articles etc.) so I applied fixes.